Merge requests
These are good practices that should be used when composing merge request. Please always keep in mind that reviewer switches from his current task and spends time to make your code even more cool so it's good when everything is obvious and clear in your merge request.
"What can I do for reviewer?"
- Assign merge request to yourself and add you reviewer to the "Reviewer" section. Reviewer should know that he's about to review something after all 😉
- Review your own code before sending it to reviewer.
- Don't forget to use JIRA task(s) ID(s) in merge request title and/or description. This way reviewer can refer to JIRA issue.
- Good tone is to provide feature/task description and add images from simulator/device to make reviewer easier to understand what is going on here.
- Please run test and linter before creating merge request.
Note for reviewer
From reviewer side patience is important. Don't forget that you're reviewing the result of developer working for few hours or even days. Respect to other's work is the key. Please don't use comments like "Fix this!", "It's awful!" and so on. In case your have questions - you're free to ask them in comments. Refer to guidelines, best practices, your own examples in your comments if you can. And be ready that you can be wrong as well 😉
Merge requests examples
Below are good merge requests examples from our Gitlab: